Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added basisOfRecord examples #119

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Added basisOfRecord examples #119

merged 1 commit into from
Apr 11, 2024

Conversation

timvdstap
Copy link
Contributor

Proposing adding a few basisOfRecord examples to complete the list of options.

@timvdstap timvdstap requested review from MathewBiddle and jdpye April 11, 2024 18:18
@timvdstap
Copy link
Contributor Author

timvdstap commented Apr 11, 2024 •
edited
Loading

I'm also wondering whether we might want to change the example of organismQuantityType to e.g. 'Relative Abundance percentage' -- or am I being too picky now?

MathewBiddle
MathewBiddle approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@MathewBiddle MathewBiddle merged commit 6ab83d9 into gh-pages Apr 11, 2024
2 checks passed
@MathewBiddle MathewBiddle deleted the timvdstap-patch-3 branch April 11, 2024 20:08
@MathewBiddle MathewBiddle mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathewBiddle MathewBiddle MathewBiddle approved these changes

@jdpye jdpye Awaiting requested review from jdpye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timvdstap @MathewBiddle