Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: correct Data Cleaning code #115

Merged
merged 8 commits into from
Mar 15, 2024
Merged

WIP: correct Data Cleaning code #115

merged 8 commits into from
Mar 15, 2024

Conversation

jdpye
Copy link
Contributor

@jdpye jdpye commented Mar 15, 2024

Working through the examples and correcting code snippets now. Fixed some of the R datetime examples, work in progress until I get the Python ones tested as well.

@jdpye
Copy link
Contributor Author

jdpye commented Mar 15, 2024

Because I'm not a good branch juggler today, it seems I'll be sneaking a draft of the acoustics lesson in as well.

@jdpye
Copy link
Contributor Author

jdpye commented Mar 15, 2024

The WoRMS Taxon Match form is doing some pretty bad things to the default input dataset species.csv . This method may need a rewrite of its example data, I can't seem to get it to respect the carriage return style of the file with any of the options, at least not on this Mac.

@MathewBiddle
Copy link
Contributor

Who do we contact at https://www.marinespecies.org/aphia.php?p=match to check the service?

@MathewBiddle
Copy link
Contributor

something went haywire with the formatting to jekyll
image
debugging now.

@jdpye
Copy link
Contributor Author

jdpye commented Mar 15, 2024

Ah sorry about that, I'm flying blind editor-wise, didn't local-build before i pushed.

@MathewBiddle
Copy link
Contributor

No worries, that's why I'm here. I'll fix the syntax stuff 😄

@MathewBiddle MathewBiddle self-requested a review March 15, 2024 18:28
allowing episode formatting in extras
renaming two pages back to original names
Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes. Mainly to add telemetry as an extra instead of an episode. Limits the amount of file name changing we have to do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to the _extras/ folder to sit next to eDNA.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be reverted back to 07

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be reverted back to 08

Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging

@MathewBiddle MathewBiddle merged commit abf1458 into ioos:gh-pages Mar 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants