Skip to content

Commit

Permalink
feat: migrate to Angular 19 for ionic start and plugin explorer
Browse files Browse the repository at this point in the history
  • Loading branch information
@dtarnawsky
dtarnawsky committed Nov 26, 2024
1 parent 01b17a6 commit 228b605
Show file tree
Hide file tree
Showing 11 changed files with 7,593 additions and 5,289 deletions.
6,301 changes: 3,717 additions & 2,584 deletions ionic-start/package-lock.json
View file

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions ionic-start/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,23 @@
"test": "ng test"
},
"dependencies": {
"@angular/animations": "^18.2.11",
"@angular/common": "^18.2.11",
"@angular/compiler": "^18.2.11",
"@angular/core": "^18.2.11",
"@angular/forms": "^18.2.11",
"@angular/platform-browser": "^18.2.11",
"@angular/platform-browser-dynamic": "^18.2.11",
"@angular/router": "^18.2.11",
"@angular/animations": "^19.0.1",
"@angular/common": "^19.0.1",
"@angular/compiler": "^19.0.1",
"@angular/core": "^19.0.1",
"@angular/forms": "^19.0.1",
"@angular/platform-browser": "^19.0.1",
"@angular/platform-browser-dynamic": "^19.0.1",
"@angular/router": "^19.0.1",
"@vscode/webview-ui-toolkit": "1.4.0",
"rxjs": "~7.5.0",
"tslib": "2.6.0",
"zone.js": "~0.14.10"
"zone.js": "~0.15.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^18.2.11",
"@angular/cli": "^18.2.11",
"@angular/compiler-cli": "^18.2.11",
"@angular-devkit/build-angular": "^19.0.2",
"@angular/cli": "^19.0.2",
"@angular/compiler-cli": "^19.0.1",
"@types/jasmine": "4.3.5",
"@types/node": "18.15.11",
"@types/vscode-webview": "1.57.5",
Expand Down
110 changes: 59 additions & 51 deletions ionic-start/src/app/app.component.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<main [ngClass]="ready ? 'show' : 'hide'">
<ng-template [ngIf]="!creating" [ngIfElse]="isCreating">
@if (!creating) {
<h1>New Ionic Project</h1>

<p>Name</p>
<vscode-text-field
id="projectName"
Expand All @@ -10,9 +9,10 @@ <h1>New Ionic Project</h1>
placeholder="The Name of your project"
></vscode-text-field>
<div class="msg">
<vscode-tag *ngIf="nameError">Please specify a name for your project</vscode-tag>
@if (nameError) {
<vscode-tag>Please specify a name for your project</vscode-tag>
}
</div>

<p>Folder</p>
<div class="bar" style="gap: unset">
<div (click)="chooseFolder()" class="folder-bar">
Expand All @@ -27,73 +27,81 @@ <h1>New Ionic Project</h1>
>•••</vscode-button
>
</div>

<div class="bar">
<div>
<p>Framework</p>
<div class="rows">
<div *ngFor="let framework of frameworks" class="gap">
<vscode-button appearance="icon" [class]="framework.appearance" (click)="select(framework)">
<div class="framework">
<img class="ionicon" [src]="assetsUri + '/logo-' + framework.icon + '.svg'" />
<p>{{ framework.name }}</p>
</div>
</vscode-button>
</div>
@for (framework of frameworks; track framework) {
<div class="gap">
<vscode-button appearance="icon" [class]="framework.appearance" (click)="select(framework)">
<div class="framework">
<img class="ionicon" [src]="assetsUri + '/logo-' + framework.icon + '.svg'" />
<p>{{ framework.name }}</p>
</div>
</vscode-button>
</div>
}
</div>
</div>
<div [ngClass]="showTargets ? 'show' : 'hide'">
<p>Targets</p>
<div class="rows">
<div *ngFor="let target of targets" class="gap">
<vscode-button appearance="icon" [class]="target.appearance" (click)="selectTarget(target)">
<div class="framework">
<img class="ionicon" [src]="assetsUri + '/' + target.icon + '.svg'" />
<p>{{ target.name }}</p>
</div>
</vscode-button>
</div>
@for (target of targets; track target) {
<div class="gap">
<vscode-button appearance="icon" [class]="target.appearance" (click)="selectTarget(target)">
<div class="framework">
<img class="ionicon" [src]="assetsUri + '/' + target.icon + '.svg'" />
<p>{{ target.name }}</p>
</div>
</vscode-button>
</div>
}
</div>
</div>
</div>
<div *ngIf="frameworkTemplates.length > 0">
<p>Template</p>
<div class="rows">
<div *ngFor="let template of frameworkTemplates" class="gap">
<vscode-button
class="tooltip"
appearance="icon"
[class]="template.appearance"
(click)="selectTemplate(template)"
>
<div class="framework">
<img class="ionicon" [src]="assetsUri + '/' + template.icon + '.svg'" />
<p>{{ template.title }}</p>
@if (frameworkTemplates.length > 0) {
<div>
<p>Template</p>
<div class="rows">
@for (template of frameworkTemplates; track template) {
<div class="gap">
<vscode-button
class="tooltip"
appearance="icon"
[class]="template.appearance"
(click)="selectTemplate(template)"
>
<div class="framework">
<img class="ionicon" [src]="assetsUri + '/' + template.icon + '.svg'" />
<p>{{ template.title }}</p>
</div>
<span class="tooltiptext">{{ template.description }}</span>
</vscode-button>
</div>
<span class="tooltiptext">{{ template.description }}</span>
</vscode-button>
}
</div>
<div class="pad-top"></div>
<vscode-divider></vscode-divider>
<div class="bar-end pad-top">
<vscode-button (click)="create()">Create Project</vscode-button>
</div>
</div>
<div class="pad-top"></div>
<vscode-divider></vscode-divider>
<div class="bar-end pad-top">
<vscode-button (click)="create()">Create Project</vscode-button>
</div>
</div>
<div *ngIf="!showTargets">
<div class="pad-top"></div>
<vscode-divider></vscode-divider>
<div class="bar-end pad-top">
<vscode-button (click)="create()">Create Plugin</vscode-button>
}
@if (!showTargets) {
<div>
<div class="pad-top"></div>
<vscode-divider></vscode-divider>
<div class="bar-end pad-top">
<vscode-button (click)="create()">Create Plugin</vscode-button>
</div>
</div>
</div>
</ng-template>
<ng-template #isCreating>
}
} @else {
<div class="flex">
<div class="progress">
<img class="pulse" [src]="assetsUri + '/ionic.svg'" />
<vscode-label>Please Wait</vscode-label>
</div>
</div>
</ng-template>
}
</main>
1 change: 0 additions & 1 deletion ionic-start/src/app/app.component.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ interface Target {
selector: 'app-root',
templateUrl: './app.component.html',
styleUrls: ['./app.component.css'],
standalone: true,
imports: [BrowserModule, FormsModule],
schemas: [CUSTOM_ELEMENTS_SCHEMA],
})
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 228b605

Please sign in to comment.