Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): ensure referenceNode is child node of styleContainerNode #5994

Conversation

tweis
Copy link
Contributor

@tweis tweis commented Sep 24, 2024

What is the current behavior?

GitHub Issue Number: #5993

What is the new behavior?

With this bugfix, only a style node within the styleContainerNode is searched for.

Documentation

--

Does this introduce a breaking change?

  • Yes
  • No

Testing

--

Other information

--

@tweis tweis requested a review from a team as a code owner September 24, 2024 13:18
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tanner-reits tanner-reits added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2024
@tanner-reits tanner-reits added this pull request to the merge queue Sep 24, 2024
Merged via the queue into ionic-team:main with commit a02bc36 Sep 24, 2024
88 checks passed
@christian-bromann
Copy link
Member

Released in Stencil v4.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants