-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] feat: add type parameters to class name #3488
base: main
Are you sure you want to change the base?
[READY] feat: add type parameters to class name #3488
Conversation
Hello @rwaskiewicz, the browserstack test failing with 30s timeout. Is that a code issue or a workload thing? Thx |
cf90f45
to
22d9858
Compare
feat: add type parameters to class name
@deleonio it appears they're running now...maybe a result of closing/opening the PR? 🤔 |
Hi @rwaskiewicz, browserstack was a little bit random - but now everything looks fine. I set the PR to ready - I hope it is okay. My next PRs:
|
Output-Targets needs stencil release ...
|
e84f6ac
to
008d1dd
Compare
Thanks @deleonio! For a bigger feature like this, I'm going to label this for the team to discuss and review! |
Hello together, this feature is very important for us and it would be nice if you take a look at it. Thanks a lot |
Hey @deleonio, This is currently in our backlog for the team to discuss. It's a interesting feature, but one that we'd like to take the time to discuss as a team. I don't have an ETA for you at this moment, and can't quite promise when we'll have the chance to take a look. Thanks! |
…t/add-type-parameters-to-class-name
Conflicts solved. |
Hey! I would also like to use this feature. Thanks for opening this PR and I hope it can get merged soon. |
Hi @jackdriscollukg, thanks for your support! I see that you also focused on a11y - you should follow us on our community - https://github.com/public-ui/kolibri. You are welcome! |
Hi @rwaskiewicz, can you make a statement about this? Is the feature coming and if so, when? |
Hey @deleonio, the team has this in the backlog and will review when they can. You do not need to ask for an update or tag various members of the ionic org 😄 |
Hello @mhartington, thank you very much for your reply! I think it is possible to ask from time to time. We want to point out that maybe there is a feature that is not prioritized high enough. Also, the PR is not new, seems to be well integrated (x-resyncs with no conflicts) and you have unfortunately mostly not responded. Basically, I have to conclude that this feature is not prioritized high enough and thus does not come into focus for editing. The thing is, this feature vastly improves numerous typing situations while remaining simple. This is a great pity. We've been thinking about forking Stencil for months now - but it's better to contribute to Stencil than to open special construction sites. With kind regards |
Any further update on getting this merged? |
Hi, in our team we are talking about this feature and we think it is interesting in general. Only for Angular with its proprietary template language it is unusable. So, what can we do? |
@deleonio - I always thought this looked useful :) |
YES! We will use that approach for our tables and form fields ... https://github.com/public-ui/kolibri/wiki/%C3%9Cbersicht-Input%E2%80%90Komponenten |
If we can get an updated version of this patch I think we can work on this to get it merged. To make this simple for me, let's make sure the code is well documented, we have user documentation for it and proper test coverage. |
We are currently working on our major release 3 with massive new features in rendering, BEM, type management and event handling. But 2025 ;-) ... the tiny list - https://github.com/public-ui/kolibri/wiki/Stencil-Collaboration |
Awesome, you know how to reach me 😉 |
TODO's
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm test
) were run locally and passednpm run test.karma.prod
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: #2895
What is the new behavior?
Does this introduce a breaking change?
Testing
Other information