fix(compiler): Prevent extTransformsPlugin from outputting collection dependency css
#3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on dependency css
George-Payne
force-pushed
the
prevent-ext-transforms-plugin-from-outputing-collection-dependency-css
branch
from
186d265
to
efc58a7
Compare
George-Payne
changed the title
extTransformsPlugin from outputting collection dependency cssextTransformsPlugin from outputting collection dependency css
|
patch works here. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: #3305
What is the new behavior?
extTransformsPluginwill no longer output collection dependency css when building collection files.Does this introduce a breaking change?
Testing
Linked build of stencil to reproduction lib and rebuilt lib.
Other information