Skip to content

Commit

Permalink
fix(types): add controlslist to html declarations (#6026)
Browse files Browse the repository at this point in the history
prior to this commit, using the `controlslist` attribute in a `video`
or `audio` element would result in a type checking error. with this
commit, we allow the attribute to take one of three values:
- nodownload
- nofullscreen
- noremoteplayback

note that at the time of this writing, only chromium browsers support
this attribute. it is the responsibilty of end users to determine if
using this attribute is appropraite for their projects.

fixes: #6015
  • Loading branch information
rwaskiewicz authored Oct 11, 2024
1 parent 5c4c969 commit e71453e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/declarations/stencil-public-runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1129,6 +1129,8 @@ export namespace JSXBase {
autoPlay?: boolean;
autoplay?: boolean | string;
controls?: boolean;
controlslist?: 'nodownload' | 'nofullscreen' | 'noremoteplayback';
controlsList?: 'nodownload' | 'nofullscreen' | 'noremoteplayback';
crossOrigin?: string;
crossorigin?: string;
loop?: boolean;
Expand Down

0 comments on commit e71453e

Please sign in to comment.