fix(react): update list starter for correct styles and back button text #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandyscarney
requested review from
JoaoFerreira-FrontEnd and
thetaPC
and removed request for
a team
|
@brandyscarney are you still wanting a review for this? |
|
@thetaPC Yes I just haven't had time to look into the failing test. |
thetaPC
requested changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The React list starter was not overriding the Ionic styles for label, resulting in it looking different compared to the Angular list starter. This updates the CSS to target an
IonItemwith anidso that the styles are properly overridden. Additionally, I updated the back button text for theViewMessageview because it should only display oniosmode and it was displaying formd.