refactor: use imported dark theme #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapsandapps
requested review from
averyjohnston
and removed request for
a team
averyjohnston
suggested changes
Jan 16, 2024
Comment on lines
1
to
2
| // Ionic Variables and Theming. For more info, please see: | ||
| // http://ionicframework.com/docs/theming/ |
There was a problem hiding this comment.
This comment is no longer entirely accurate since the light theme colors have also been removed. We may be able to just remove it? (Here and in the other starters.)
There was a problem hiding this comment.
Hmm, yeah, this comment should at least change. But I was thinking that this is the file where you would override the default themes (the directory is theme, after all), so the docs link seems still relevant?
I guess there are three options (not all mutually exclusive):
- Remove the file
- Move the file
- Change text of comment and maybe add an example of an override
I would lean towards just doing 3, maybe something as simple as:
/* For information on how to create your own theme, please see:
http://ionicframework.com/docs/theming/ */
Edit: oops, I forgot to mention option 4: removing the comment
There was a problem hiding this comment.
Option 3 works for me!
averyjohnston
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.