refactor(searchbar): update default styles for ionic theme #29917
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -143,19 +143,6 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { | |||
| await expect(searchbar).toHaveScreenshot(screenshot(`searchbar-color`)); | |||
| }); | |||
|
|
|||
| test('should render disabled searchbar', async ({ page }) => { | |||
There was a problem hiding this comment.
Moved this to the states test folder.
There was a problem hiding this comment.
Actually do we need this file since we are already using tokens?
There was a problem hiding this comment.
I added this file because I wanted the padding logic separate so it would be easier to read. Plus, if one of them changes like gap then the dev wouldn't have to worry about updating padding start or end. Thoughts?
There was a problem hiding this comment.
Should the arrow be flipped here?
There was a problem hiding this comment.
I thought that too but it's not flipped in md. I ended up just leaving it as is.
|
|
||
| transform: translateY(-50%); | ||
| font-size: globals.$ionic-font-size-400; |
|
|
||
| /* Hover */ | ||
| :host(:hover) { | ||
| --icon-color: #{globals.$ionic-color-neutral-900}; |
There was a problem hiding this comment.
I am seeing color/neutral/800 in Figma on hover, is this right?
There was a problem hiding this comment.
You're right. It seems that the only thing that changes is the background: 127027c
Issue number: internal
What is the current behavior?
Ionic theme: Searchbar does not match design.
What is the new behavior?
Does this introduce a breaking change?
Other information
Preview