feat(segment): add segment-view and segment-content components #29882
+1,130
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
brandyscarney
commented
Sep 23, 2024
| * @param smoothScroll: Whether to animate the scroll transition. | ||
| */ | ||
| @Method() | ||
| async setContent(id: string, smoothScroll = true) { |
There was a problem hiding this comment.
This could be an internal method if we want, but I added an example using it because it seems useful to expose it.
brandyscarney
commented
Sep 23, 2024
… get scrollDistance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #17804
What is the current behavior?
Developers need to create their own components, use
divelements, or integrate Swiper to connect an<ion-segment>with a swipeable content view:What is the new behavior?
<ion-segment>does not animate when thevaluechanges dynamically<ion-segment-view>component to act as a scroll snap container<ion-segment-content>component to contain each content that should be linked to a segment buttonion-segment-viewto verify that the proper content displays based on the current segment buttonDoes this introduce a breaking change?
Other information