chore(angular-server): add sync github action and update @stencil/core to 4.19.1 in core #29670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
changed the title
brandyscarney
force-pushed
the
chore-fix-angular-server-build
branch
from
e3b4eec to
24fbc33
Compare
brandyscarney
changed the title
sean-perkins
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Looks good, tested against https://github.com/sean-perkins/ionic-angular-universal-example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
This PR does a couple things:
1 - Adds a
synccommand to get the latestcorebuild inangular-serverThe release process for
angular-serverfailed here. This failure was only made apparent because the Lerna command here runs prior to building each package.This should have been caught by CI on the update to @stencil/core to v4.19.0, but the
angular-serverpackage is the only package that doesn't synccorebefore it builds. This PR adds asynccommand so thatangular-serverwill use the latest core build during the normal build action.2 - Resolving types errors in
angular-serverAfter properly syncing
coreinangular-serverusing the command added, running build fails with the following:This was a regression in Stencil.
@stencil/corehas been updated to resolve these errors so the build passes.