bug: AppFlow fails and exits with missing hook scripts

[davidquon]

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:
Scripts that are defined in the plugin.xml but not found causes AppFlow to exit even though it says they will just be skipped such as if they are defined like this but not found:

  <hook type="after_plugin_install" src="scripts/after_plugin_add.js" />
  <hook type="after_platform_add" src="scripts/after_plugin_add.js" />
  <hook type="before_plugin_uninstall" src="scripts/before_plugin_rm.js" />

Can see this issue for reference:
ReallySmallSoftware/cordova-plugin-firebase-crashlytics#43

iOS and Android both work fine locally. This only seems to happen with iOS builds using AppFlow as the Android build seemed to continue and build successfully with the same missing hook files.

Expected behavior:
Expected behavior is for AppFlow to do what is stated which is ignore script hook files that are not found and move on without them.

Steps to reproduce:
Can include the plugin cordova-plugin-firebase-crashlytics and attempt to make an iOS build with AppFlow. The job will fail and exit as described below.

Related code:

Other information:

Script file does't exist and will be skipped: /Users/ionic/builds/project-0/plugins/cordova-plugin-firebase-crashlytics/scripts/after_plugin_add.js
\e[0m
Running after script...
$ clean-up
ERROR: Job failed: Process exited with: 1. Reason was:  ()

Ionic info:

Ionic:

   Ionic CLI                     : 6.11.11 (/Users/DQ/.nvm/versions/node/v10.20.0/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.3.1
   @angular-devkit/build-angular : 0.803.29
   @angular-devkit/schematics    : 10.0.5
   @angular/cli                  : 8.3.29
   @ionic/angular-toolkit        : 2.3.0

Cordova:

   Cordova CLI       : 10.0.0
   Cordova Platforms : android 9.0.0, ios 6.1.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 5.0.0, (and 18 other plugins)

Utility:

   cordova-res                          : 0.15.1
   native-run (update available: 1.2.1) : 1.1.0

System:

   Android SDK Tools : 26.1.1 (/Users/DQ/Library/Android/sdk)
   ios-deploy        : 1.11.0
   ios-sim           : 8.0.2
   NodeJS            : v10.20.0 (/Users/DQ/.nvm/versions/node/v10.20.0/bin/node)
   npm               : 6.14.8
   OS                : macOS Catalina
   Xcode             : Xcode 12.0.1 Build version 12A7300

[davidquon]

Also I proved this was the case by removing these lines in a forked repo and the build completed successfully for iOS using AppFlow.

  <hook type="after_plugin_install" src="scripts/after_plugin_add.js" />
  <hook type="after_platform_add" src="scripts/after_plugin_add.js" />
  <hook type="before_plugin_uninstall" src="scripts/before_plugin_rm.js" />

[ionitron-bot]

Thanks for the issue! This issue appears to be related to Ionic Appflow. We use this issue tracker exclusively for bug reports and feature requests. Please use the Ionic Appflow Support Forum to report this issue.

Thank you for using Ionic!