Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts have been removed but are referenced as hook #43

Open
marcjulian opened this issue Sep 24, 2020 · 4 comments · May be fixed by #42
Open

Scripts have been removed but are referenced as hook #43

marcjulian opened this issue Sep 24, 2020 · 4 comments · May be fixed by #42

Comments

@marcjulian
Copy link

Expected Behavior

Scripts are available for the hooks

  <hook type="after_plugin_install" src="scripts/after_plugin_add.js" />
  <hook type="after_platform_add" src="scripts/after_plugin_add.js" />
  <hook type="before_plugin_uninstall" src="scripts/before_plugin_rm.js" />

Actual Behavior

Scripts have been removed in 566833f now the hooks are failing because of the missing scripts.

Steps to Reproduce the Problem

Specifications

  • Plugin version:
  • Framework:
  • Framework version:
  • Operating system:
@marcjulian marcjulian linked a pull request Sep 24, 2020 that will close this issue
Open
@nikunjkakadiya3008
Copy link

Having the same issue. Please review PR ASAP

@davidquon
Copy link

Was about to open the same issue. Nice find @marcjulian. 👏

@davidquon davidquon mentioned this issue Oct 8, 2020
Closed
@davidquon
Copy link

This actually breaks Ionic AppFlow CI which I filed an issue for.
ionic-team/ionic-framework#22284

@Jason-Lindley
Copy link

Same issue here. Anything we can do to get this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(hooks): remove unused hooks marcjulian/cordova-plugin-firebase-crashlytics
4 participants
@davidquon @marcjulian @nikunjkakadiya3008 @Jason-Lindley