Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(google-maps): Refactored options and added feature to update the map options #1618

Closed
wants to merge 1 commit into from
Closed

feat(google-maps): Refactored options and added feature to update the map options #1618

wants to merge 1 commit into from

Conversation

AE1NS
Copy link
Contributor

@AE1NS AE1NS commented May 25, 2023 •
edited
Loading

This refactorings simplify the map options handling and therefore remove many methods, that can now be set in the instantiation of the map but also be updated with a new method.

Closes #1617

@AE1NS AE1NS force-pushed the options-refactoring branch 11 times, most recently from 4c9160f to 6444061 Compare May 31, 2023 07:15
@AE1NS
Copy link
Contributor Author

AE1NS commented May 31, 2023

I also fixed an issue with the padding values in Android, that were used as DP value. I used the getScaledPixels to convert the DP values to screen PX. Now its working fine.

@AE1NS AE1NS force-pushed the options-refactoring branch 2 times, most recently from a375723 to c80305e Compare June 6, 2023 09:47
@AE1NS AE1NS force-pushed the options-refactoring branch from c80305e to 586c177 Compare June 19, 2023 14:11
@AE1NS AE1NS force-pushed the options-refactoring branch from 586c177 to ac75252 Compare July 4, 2023 13:26
@paulstelzer paulstelzer mentioned this pull request Jul 4, 2023
Closed
markemer
markemer requested changes Jul 26, 2023
View reviewed changes
google-maps/ios/Plugin/CapacitorGoogleMapsPlugin.m
@@ -19,13 +20,6 @@
CAP_PLUGIN_METHOD(disableClustering, CAPPluginReturnPromise);
CAP_PLUGIN_METHOD(destroy, CAPPluginReturnPromise);
CAP_PLUGIN_METHOD(setCamera, CAPPluginReturnPromise);
CAP_PLUGIN_METHOD(getMapType, CAPPluginReturnPromise);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change - these should be kept, perhaps marked as deprecated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ac75252#diff-e887271a6e743973df748b0b83f29f5250ad28c088c82e1aacadfbb4ffc3d1b4R460
The method still exists in the map.ts with the same return type and is marked as deprecetd there. It was just removed from the native implementations because its replaced by the new solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you still waiting for an update here or is it 'solved' with my comment? I just want to make sure that I am not the reason why this is on hold.

@AE1NS AE1NS force-pushed the options-refactoring branch from ac75252 to 13b9ec7 Compare July 27, 2023 11:44
@AE1NS AE1NS force-pushed the options-refactoring branch 3 times, most recently from 0326863 to 4e7c35b Compare March 1, 2024 13:45
@AE1NS AE1NS force-pushed the options-refactoring branch from 4e7c35b to 6c9963d Compare March 12, 2024 13:57
@AE1NS
Copy link
Contributor Author

AE1NS commented Jun 18, 2024

Moved ionic-team/capacitor-google-maps#26

@AE1NS AE1NS closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markemer markemer markemer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@capacitor/google-maps] Refactor options and extend a method to update the map options
3 participants
@AE1NS @markemer @A1Jan