Dont mask if there's no auth.

ionelmc · May 21, 2024 · ff0d0c8 · ff0d0c8
1 parent 8ef4ac5
commit ff0d0c8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -2,6 +2,11 @@
 Changelog
 =========
 
+5.1.1 (2024-05-21)
+------------------
+
+* Do not display an authentication mask for http protocols if there are no actual credentials specified.
+
 5.1.0 (2024-04-12)
 ------------------
 

diff --git a/src/holdup/checks.py b/src/holdup/checks.py
@@ -158,7 +158,7 @@ def __repr__(self):
 
     def display_definition(self, *, verbose_passwords):
         url = self.parsed_url
-        if not verbose_passwords:
+        if url.username and not verbose_passwords:
             if not url.password:
                 mask = "******"
             else: