Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isConnected query removed #125

Merged
merged 6 commits into from
Sep 4, 2023
Merged

isConnected query removed #125

merged 6 commits into from
Sep 4, 2023

Conversation

TDCroPower
Copy link

No description provided.

@mcm1957
Copy link
Member

mcm1957 commented Sep 3, 2023

Thanks for the PR.

Did you test the behavior in case no connection is available? As you do no longer check isConnected the requests most likely will fail. So please verify (if not yet done) that

-) the adapter does not crash / shutdown due to the failing poll requests
-) the ioBroker log is not flooded with error messages

Thanks in advance for testing
@Apollon77 - FYI if you have more information

@Lucky-ESA
Looks like you fixed (or at least tried to fix) the same issue a short time ago. Could you check this PR / drop any statement please.

@TDCroPower
Copy link
Author

TDCroPower commented Sep 3, 2023

@mcm1957 I have just tested my fork.
Box Standby On/Off -> works
Adapter Stop/Start -> works
Box restart -> works

@Lucky-ESA
Copy link
Contributor

"isConnected" is also for deepstandby
Unnecessary requests are made.

@TDCroPower
Copy link
Author

I have still committed the logical next version numbers.
In all tests the change was successful.
When I send my box to DeepStandby, no objects are updated and enigma2-CONNECTION is set to false.
No error logs or anything like that are seen.
Don't see any problems to release this as an update.

@Apollon77
Copy link
Member

@TDCroPower Thank you cool work!

please remove the version increase and such and just add a "WORK IN PROGRESS" section to the readme ... the release script we use willdo all this version increase automatically.

@TDCroPower
Copy link
Author

@Apollon77 did a revert to the version changes

README.md Outdated Show resolved Hide resolved
@mcm1957 mcm1957 merged commit a34bd1f into iobroker-community-adapters:master Sep 4, 2023
12 checks passed
@mcm1957 mcm1957 added bug and removed bug labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants