-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add clean-dir.js and remove rimraf #273
base: main
Are you sure you want to change the base?
Conversation
Please mention the new functionality in the Readme |
Isn't this functionality provided by iobroker/build-tools anyway? build-tools is used for react - at least for new projects. Maybe it should be used for Typescript too. I suggest to discuss with @GermanBluefox |
Yes but these tools are JS methods ... here we have CLI ... thats fine. |
@Apollon77 As rimraf needs to be removed from adapter package.json it would make sense to add a suggestion to iobroker adapter checker after a new version of adapter-dev is available to (eventually) replace rimraf. @ticaki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new CLI "tool" should be documented like the existing ones, for example:
https://github.com/ioBroker/adapter-dev?tab=readme-ov-file#compile-adapter-files
bin/clean-dir.js
Outdated
@@ -0,0 +1,23 @@ | |||
/** | |||
* example package.json entry: | |||
* "prebuild": "node ./node_modules/@iobroker/adapter-dev/bin/clean-dir.js ./build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean-dir.js
should be added to adapter-dev
s package.json bin
, like the existing tools. That way the call on the developer side would look like this:
* "prebuild": "node ./node_modules/@iobroker/adapter-dev/bin/clean-dir.js ./build", | |
* "prebuild": "clean-dir ./build", |
@mcm1957 @AlCalzone |
Als Ersatz für rimraf
Edit: in der package.json wurde rimraf aus den deps entfernt und in script ein Aufruf angepasst