-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Update some links #1364
base: staging
Are you sure you want to change the base?
[UI] Update some links #1364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the inline comments
- Compiling the translation is missing. From https://doc.inyokaproject.org/getting_started.html#translate-inyoka:
If the translations are done, run the following command to compile the corresponding
*.mo
files (binary translation files)(inyoka)$ python manage.py compilemessages
and restart the server for testing.
It is recommended to add the
*.mo
files in a seperate commit, because they cannot
be merged by git. In case of a merge conflict, the commit can be dropped, the*.po
files merged
and the*.mo
files compiled again.
- Lastly, a more an organizational question: When should i merge the changes?
As old and new pages don't display the same content at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit surprised that basically the whole file was commented. That would mean, the strings are not used. However, they are.
Just as an idea for a cause: Did you check, if your development_settings
fits to the example_development_settings
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what could have been the cause; I removed the comments and re-created the message files, then it worked.
Replace links in the sidebar pointing to backlink pages with a separately created page so that every visitor has access to them and the displayed text can be amended. Also merge the two categories for extendable and incorrect articles into one.
8f4aef8
to
4336c9c
Compare
4336c9c
to
b815081
Compare
Oh, sorry, I must admit I'm not too familiar with gettext. Done.
Do you mean that change should be publicly announced? It would be good if you could render all pages with the extendable template manually beforehand, so that the tags are added. |
That was not really my intention by the comment. I wanted to know if the new wiki page is already ready. Or if there will be more tweaking with the MetaFilter, before i should merge this PR. Regarding the announcement however, feel free to add at least a line to the change log for the next release in this PR. Then it's more likely it will be mentioned at least in the uu.de's UWR. That's IMO enough for this change.
After each deployment (and every night) all pages are rendered. Nevertheless, this will only affect the HTML, not the metadata. An example: If we change the rendered HTML of headings in InyokaMarkup, that's already covered. In contrast, metadata AFAIR is only updated, when a new revision is saved. I can try in a new PR to add metadata regeneration to the existing mechanism. |
Replace links in the sidebar pointing to backlink pages with a separately created page so that every visitor has access to them and the displayed text can be amended. Also merge the two categories for extendable and incorrect articles into one.