Extract signer roles

invopop · Dec 21, 2023 · b557fcc · b557fcc
1 parent 15754a7
commit b557fcc
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -29,7 +29,7 @@ func main() {
  }
  // Using XAdES FacturaE example policy config
  xades := &xmldsig.XAdESConfig{
- Role: xmldsig.XAdESThirdParty,
+ Role: xmldsig.XAdESSignerRole("third party"),
  Description: "test",
  Policy: &xmldsig.XAdESPolicyConfig{
  URL: "http://www.facturae.es/politica_de_firma_formato_facturae/politica_de_firma_formato_facturae_v3_1.pdf",

diff --git a/signature_test.go b/signature_test.go
@@ -84,7 +84,7 @@ func TestSignature(t *testing.T) {
 
 func xadesConfig() *xmldsig.XAdESConfig {
  return &xmldsig.XAdESConfig{
- Role: xmldsig.XAdESThirdParty,
+ Role: xmldsig.XAdESSignerRole("third party"),
  Description: "test",
  Policy: &xmldsig.XAdESPolicyConfig{
  URL: "http://www.facturae.es/politica_de_firma_formato_facturae/politica_de_firma_formato_facturae_v3_1.pdf",

diff --git a/xmldsig.go b/xmldsig.go
@@ -25,13 +25,6 @@ type options struct {
 // XAdESSignerRole defines the accepted signer roles
 type XAdESSignerRole string
 
-// Pre-defined XAdES Signer Roles
-const (
- XAdESSupplier XAdESSignerRole = "supplier"
- XAdESCustomer XAdESSignerRole = "customer"
- XAdESThirdParty XAdESSignerRole = "third party"
-)
-
 // XAdESConfig defines what is expected for the configuration.
 type XAdESConfig struct {
  Role XAdESSignerRole `json:"role"`