Bump axios to stable release version #1990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@turbo124/@beganovich I'm seeing the other PRs mention you for a review. A review for this one here likely comes with just little effort. If it's better to rebase the request on the dev branch, please let me know, I wasn't sure about destination you prefer. |
|
Hey there, thanks for your contribution. Can you please change the target to Thanks. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Before merging can you please verify if we cover all these cases? https://github.com/bmuenzenmeyer/axios-1.0.0-migration-guide |
|
@beganovich thanks for taking care. After checking again with linked migration guide, I don't see any caveats. So it should be good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR bumps axios to it's stable version. The major v1 was released in October 2022 and is where development and fixes are continued.
This resolves that it is currently not included in regular package updates but being stuck at the old development version due to the major version difference.