This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
[CI-1023]: Feature-request: allow negative taxes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdrost7
changed the title
|
I'll take a look to the current state to update the branch |
|
This is ready to be reviewed @nielsdrost7. It should be good to remove the need of creating all the assets locally and replacing that with some github action that publish the package, but that's for another PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by @danybmx
Description
Allows negative taxes
Related Issue
Closes crater-invoice-inc#315
Closes crater-invoice-inc#462
Closes crater-invoice-inc#880
Closes crater-invoice-inc#1023
Motivation and Context
Negative taxes are needed in certain countries
Pull Request Checklist
Issue Type (Please check one or more)
Might need to redo this branch.
@danybmx what do you think?
There are many changes because the assets and thats a bit annoying, my changes are only at:
database/migrations/2023_05_25_225047_taxes_amount_as_signed.php
resources/scripts/admin/components/modal-components/TaxTypeModal.vue