feat(firestore-sheets-sync): initial commit #52
Conversation
… into @invertase/firestore-google-sheets
| @@ -0,0 +1,119 @@ | |||
| name: sync-firestore-sheets | |||
There was a problem hiding this comment.
| name: sync-firestore-sheets | |
| name: sync-firestore-sheets |
Would suggest changing the name to match the convention of the other extensions, e.g. the service name goes first, so firestore-sheets-sync (like the folder name)
| - param: FIELDS_TO_SYNC | ||
| label: Fields to sync | ||
| description: > | ||
| A list of comma-separated fields to sync to the Google Sheet. If left blank, no fields will be synced. |
There was a problem hiding this comment.
Does it not make more sense to Sync all fields if left empty?
There was a problem hiding this comment.
Required since Firestore schemaless, making the user input these fields ensures only those fields are synced, since otherwise multiple records with different fields may not work since we only have a single header row in the sheet for all data rows
At least that's my understanding :D
There was a problem hiding this comment.
As Mike said, this is the reason the field names are required
| const set1 = new Set(arr1); | ||
| const set2 = new Set(arr2); | ||
| return ( | ||
| arr1.every(item => set2.has(item)) && arr2.every(item => set1.has(item)) |
There was a problem hiding this comment.
This could probably be more efficient;
- Check the
.sizeis equal to each other - If it is, just compare a with b.
Co-authored-by: Mike Diarmid <[email protected]>
Co-authored-by: Mike Diarmid <[email protected]>
Co-authored-by: Mike Diarmid <[email protected]>
Co-authored-by: Mike Diarmid <[email protected]>
Co-authored-by: Mike Diarmid <[email protected]>
Co-authored-by: Mike Diarmid <[email protected]>
No description provided.