Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THIS WILL NOT BE MERGED: Just to check the procedure #141

Closed
wants to merge 2 commits into from

Conversation

psaiz
Copy link
Contributor

@psaiz psaiz commented Sep 13, 2023

@psaiz psaiz marked this pull request as draft September 13, 2023 11:10
@psaiz psaiz requested a review from slint September 13, 2023 11:10
"conceprecid",
"doi",
]:
painless += f'ctx,_source.remove("{f}")'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
painless += f'ctx,_source.remove("{f}")'
painless += f'ctx._source.remove("{f}")'

Comment on lines 185 to 189
"bucket_id",
"file_key",
"referrer",
"size",
"file_id",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"bucket_id",
"file_key",
"referrer",
"size",
"file_id",

We can keep all of these as well, they're available in the new mappings

@psaiz psaiz closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants