Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: granular env-based solution for connection strings #2918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Nov 21, 2024

❤️ Thank you for your contribution!

Description

I rearranged the logic to prioritize individual environment variables (DB_HOST, DB_PASSWORD, etc.) to build URI.
If these are missing, it checks for the full value. As a fallback, it defaults to the final fallback value.
This asserts that user-provided values take precedence.
This PR includes:

  • Build db URI
  • Build Redis URL
  • Build AMQP URL

Partially closes: inveniosoftware/helm-invenio#112

Questions:

  • Should the logic remain in this package, or should it be moved to another one e.g.: invenio_app or invenio_config and imported here?

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13 Samk13 requested a review from Copilot November 21, 2024 00:52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

* build db uri
* build redis url
* build mq url

partially closes: inveniosoftware/helm-invenio#112
@Samk13 Samk13 marked this pull request as ready for review November 22, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Granular env-based solution for "connection string"-like config
2 participants