Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: filter out robots and flag machines #2809

Merged
merged 1 commit into from
Aug 29, 2024
Merged

config: filter out robots and flag machines #2809

merged 1 commit into from
Aug 29, 2024

Conversation

slint
Copy link
Member

@slint slint commented Aug 26, 2024 •
edited
Loading

alejandromumo
alejandromumo approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@alejandromumo alejandromumo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, will be sorted when invenio_stats is released I believe

@slint
Copy link
Member Author

slint commented Aug 28, 2024

Apparently, the is_machine field was missing from the mapping for the record view events... I've added it in inveniosoftware/invenio-rdm-records#1803, so when released this will start passing

@slint slint force-pushed the fix-stats-filtering branch from 41d1fb8 to 4697ccc Compare August 28, 2024 14:21
@slint slint merged commit 8205056 into inveniosoftware:master Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikachurilova anikachurilova anikachurilova approved these changes

@alejandromumo alejandromumo alejandromumo approved these changes

@ptamarit ptamarit ptamarit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sprint Q4/2024 🎄
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slint @ptamarit @alejandromumo @anikachurilova