Mimic constructor from PDMats.jl so that PSDMat(<:Matrix{<:Integer}) does not throw #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
approved these changes
Oct 17, 2023
|
Thanks, sorry this slipped under the radar. Can you rebase this, and then it should be good to merge This isn't breaking. Per https://github.com/SciML/ColPrac#changes-that-are-not-considered-breaking
|
vandenman
force-pushed
the
mimic_constructor_PDMats
branch
from
dcdce04
to
4fee327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this discourse post, the following throws:
It also used to throw in PDMats.jl, but that was fixed in JuliaStats/PDMats.jl#117. This PR copies the changes in that PR and adds a small test.
Technically this is probably a breaking change, but PDMats.jl merged that PR in a patch release so ¯\(ツ)/¯