Loosen type signatures to support UTCDateTimes #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 12 12
Lines 848 848
=======================================
Hits 715 715
Misses 133 133
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
oxinabox
approved these changes
Jan 25, 2023
iamed2
reviewed
Jan 25, 2023
| @@ -386,8 +386,8 @@ canonicalize(target_type::Type{P}, p::P) where P <: Period = p | |||
|
|
|||
| ##### TIME ZONES ##### | |||
|
|
|||
| function TimeZones.astimezone(i::AnchoredInterval{P, ZonedDateTime, L, R}, tz::TimeZone) where {P,L,R} | |||
| function TimeZones.astimezone(i::AnchoredInterval{P, T, L, R}, tz::TimeZone) where {P,T,L,R} | |||
| return AnchoredInterval{P, ZonedDateTime, L, R}(astimezone(anchor(i), tz)) | |||
There was a problem hiding this comment.
Suggested change
| return AnchoredInterval{P, ZonedDateTime, L, R}(astimezone(anchor(i), tz)) | |
| zdt = astimezone(anchor(i), tz) | |
| return AnchoredInterval{P, typeof(zdt), L, R}(zdt) |
This could be done in the future. Probably this type of change would have to happen in a bunch of places for it to work and there's no use case right now, though, so we can hold off.
There was a problem hiding this comment.
Added an issue for it. Might want to do that at the same time that we try to make TimeZones an optional dependency.
iamed2
approved these changes
Jan 25, 2023
omus
reviewed
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.