Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impact qualification #737

Merged
merged 32 commits into from
Aug 26, 2024
Merged

Add impact qualification #737

merged 32 commits into from
Aug 26, 2024

Conversation

monsieurswag
Copy link
Contributor

No description provided.

@monsieurswag monsieurswag marked this pull request as draft August 14, 2024 09:00
Comment on lines 1683 to 1691
QUALIFICATIONS = [
("Financial", _("Financial")),
("Legal", _("Legal")),
("Reputation", _("Reputation")),
("Operational", _("Operational")),
("Confidentiality", _("Confidentiality")),
("Integrity", _("Integrity")),
("Availability", _("Availability"))
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should allow impact qualifications to be specified in risk matrices, as it is done for strength of knowledge. Most likely some users will want to have their own

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values can be what is proposed here.

@monsieurswag monsieurswag marked this pull request as ready for review August 20, 2024 13:12
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1/ The qualification can be multivalued (eg financial + confidentiality).
2/ I The addition of the status is useless, and in fact the added status is dead code.
3/ I have added an additional value "Authenticity", as this is used by some frameworks like ENS.

@monsieurswag monsieurswag marked this pull request as draft August 21, 2024 04:22
@monsieurswag monsieurswag linked an issue Aug 21, 2024 that may be closed by this pull request
@monsieurswag monsieurswag marked this pull request as ready for review August 22, 2024 15:25
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good! Just need to translate the qualification values.

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit 1b48938 into main Aug 26, 2024
15 checks passed
@eric-intuitem eric-intuitem deleted the add_impact_qualification branch August 26, 2024 19:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add impact qualification for a risk scenario
3 participants