-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add impact qualification #737
Conversation
backend/core/models.py
Outdated
QUALIFICATIONS = [ | ||
("Financial", _("Financial")), | ||
("Legal", _("Legal")), | ||
("Reputation", _("Reputation")), | ||
("Operational", _("Operational")), | ||
("Confidentiality", _("Confidentiality")), | ||
("Integrity", _("Integrity")), | ||
("Availability", _("Availability")) | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should allow impact qualifications to be specified in risk matrices, as it is done for strength of knowledge. Most likely some users will want to have their own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default values can be what is proposed here.
c772b82
to
bee6915
Compare
…ay qualification in detail view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1/ The qualification can be multivalued (eg financial + confidentiality).
2/ I The addition of the status is useless, and in fact the added status is dead code.
3/ I have added an additional value "Authenticity", as this is used by some frameworks like ENS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good! Just need to translate the qualification values.
Align specification.
7b3619a
to
1f9ac90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.