Fixed the flaky test method, testToString, in ExperimentBatchTest.java #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the flaky test method, testToString(), in ExperimentBatchTest.java due to non-deterministic iteration order of HashSet and HashMap.
The cause of the flaky test is the implementation of the 3 fields of ExperimentBatch, including labels, profile, and personalizationParameters. The current implementations are based on HashSet and HashMap, whose iteration orders are non-deterministic. Therefore, in testToString(), the two strings being compared may not be equal every time. To fix the flaky test, the implementations are changed to LinkedHashSet and LinkedHashMap so that the iteration orders are the same as the order of elements being added.