-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add progress status for moving torrents #66
feat: add progress status for moving torrents #66
Conversation
Wait, doesn't transmission return instantaneously for all cases anyway? " Location moved to {display_name}" may be misleading in this case as this may suggest that the operation is done |
hmm what would u prefer the message to be then? i think having some form of indication that the "move" command was run successfully is good to have for the user |
" Moving to {display_name}"? |
hmm that's already the message for when the command is pending though .. |
"Request to move sent!" maybe then? |
hmm that's a different format from our other messages though? adding/deleting torrent messages use the terms "added" and "deleted" so i think maybe it makes sense to use "moved" even though it's not completely accurate? |
In terms of consistency, yes, but this could be frustrating for the user. The best way to do this would be to really track the location of a torrent, and if it changes, then display the "moved successfully" message. It'd actually put the cool throbber to use |
this will likely require a much bigger chance since all torrent actions (add, remove, move) will have to be updated to track the actual state of the underlying torrent files, which can be done in another PR this PR is mainly to provide consistent ui feedback for users, since "move" is the only action with no progress feedback |
I'll be working on making it easier to implement, so don't touch it yet okay, thx |
No description provided.