Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add progress status for moving torrents #66

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

aidanaden
Copy link
Contributor

No description provided.

@aidanaden aidanaden added the done This issue or pull request has been completed label Jul 12, 2024
@aidanaden aidanaden self-assigned this Jul 12, 2024
@aidanaden aidanaden requested a review from micielski July 12, 2024 03:08
@micielski
Copy link
Contributor

Wait, doesn't transmission return instantaneously for all cases anyway? " Location moved to {display_name}" may be misleading in this case as this may suggest that the operation is done

@aidanaden
Copy link
Contributor Author

aidanaden commented Jul 13, 2024

Wait, doesn't transmission return instantaneously for all cases anyway? " Location moved to {display_name}" may be misleading in this case as this may suggest that the operation is done

hmm what would u prefer the message to be then? i think having some form of indication that the "move" command was run successfully is good to have for the user

@micielski
Copy link
Contributor

" Moving to {display_name}"?

@aidanaden
Copy link
Contributor Author

" Moving to {display_name}"?

hmm that's already the message for when the command is pending though ..

@micielski
Copy link
Contributor

hmm that's already the message for when the command is pending though ..

"Request to move sent!" maybe then?

@aidanaden
Copy link
Contributor Author

"Request to move sent!" maybe then?

hmm that's a different format from our other messages though? adding/deleting torrent messages use the terms "added" and "deleted" so i think maybe it makes sense to use "moved" even though it's not completely accurate?

@micielski
Copy link
Contributor

In terms of consistency, yes, but this could be frustrating for the user. The best way to do this would be to really track the location of a torrent, and if it changes, then display the "moved successfully" message. It'd actually put the cool throbber to use

@aidanaden
Copy link
Contributor Author

In terms of consistency, yes, but this could be frustrating for the user. The best way to do this would be to really track the location of a torrent, and if it changes, then display the "moved successfully" message. It'd actually put the cool throbber to use

this will likely require a much bigger chance since all torrent actions (add, remove, move) will have to be updated to track the actual state of the underlying torrent files, which can be done in another PR

this PR is mainly to provide consistent ui feedback for users, since "move" is the only action with no progress feedback

@micielski micielski merged commit c234a37 into intuis:main Jul 14, 2024
7 checks passed
@micielski
Copy link
Contributor

this will likely require a much bigger chance since all torrent actions (add, remove, move) will have to be updated to track the actual state of the underlying torrent files, which can be done in another PR

I'll be working on making it easier to implement, so don't touch it yet okay, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done This issue or pull request has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants