Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable headers #48 #55

Merged
merged 13 commits into from
Jul 8, 2024
Merged

configurable headers #48 #55

merged 13 commits into from
Jul 8, 2024

Conversation

micielski
Copy link
Contributor

@micielski micielski commented Jul 4, 2024

[torrents_tab]
# Available fields:
# Name, SizeWhenDone, Progress, DownloadRate, UploadRate, DownloadDir
headers = ["Name", "SizeWhenDone", "Progress", "DownloadRate", "UploadRate"]

TODO:

  • Padding header
  • Other headers (date, activity date etc)

@micielski micielski requested a review from aidanaden July 4, 2024 14:36
@micielski micielski added this to the 0.4 milestone Jul 4, 2024
rm-config/defaults/config.toml Outdated Show resolved Hide resolved
rm-config/defaults/config.toml Show resolved Hide resolved
rm-main/src/ui/tabs/torrents/rustmission_torrent.rs Outdated Show resolved Hide resolved
rm-config/src/main_config.rs Outdated Show resolved Hide resolved
@micielski
Copy link
Contributor Author

That's all the headers for now

@micielski
Copy link
Contributor Author

micielski commented Jul 6, 2024

@aidanaden I've implemented icon status, could you say if it works for you?
(it's SmallStatus in the config)

@micielski micielski added the enhancement New feature or request label Jul 7, 2024
@micielski micielski linked an issue Jul 7, 2024 that may be closed by this pull request
@aidanaden
Copy link
Contributor

@aidanaden I've implemented icon status, could you say if it works for you? (it's SmallStatus in the config)

it feels odd that the small status icons for download/upload are different from the usual download/upload icons, i think we should use the same upload/download icons throughout the app - maybe change the small icon to use the existing ones?

other than that lgtm !!

@micielski
Copy link
Contributor Author

it feels odd that the small status icons for download/upload are different from the usual download/upload icons, i think we should use the same upload/download icons throughout the app - maybe change the small icon to use the existing ones?

The ones that we use already are a bit off to the left in comparison to the other icons (for example the check mark or pause). I'm not sure if you can reproduce it, whether it is my terminal's or font's fault or is it just nerdfonts' oddity

@aidanaden
Copy link
Contributor

The ones that we use already are a bit off to the left in comparison to the other icons (for example the check mark or pause). I'm not sure if you can reproduce it, whether it is my terminal's or font's fault or is it just nerdfonts' oddity

sure - we could update the existing ones to use the new icons?

@micielski
Copy link
Contributor Author

Done

@micielski micielski merged commit 5709159 into intuis:main Jul 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizable headers
2 participants