feat: torrent tab status bar #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you saying that I have to delete my precious torrents in order to test it?? |
micielski
requested changes
Jun 27, 2024
|
By the way, I've also noticed that these statuses don't disappear. Could you also do some time::Duration and tick magic so they disappear after 5/10secs? |
haha u can just delete a small file! add a ::sleep after the delete rpc call is sent if u want to see the spinner spin (sometimes the deletion happens so fast the loading state ends almost insantly) |
yep sure - was thinking about this as well |
micielski
reviewed
Jun 27, 2024
micielski
requested changes
Jun 28, 2024
micielski
pushed a commit
that referenced
this pull request
Jul 4, 2024
* feat: torrent tab status bar * chore: remove commented * fix: compiler warnings * feat: decrement selected torrent on delete * feat: add/delete torrent name * fix: warnings * feat: cancel status bar after 5s * fix: nits * fix: tick nits * fix: comments * fix: spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35
adds status feedback when user adds or deletes a torrent
status bar closes after 5s (we can make it configurable in another PR)