configurable keybindings #23 #36
Conversation
|
@aidanaden could you test this? pretty please (but don't merge this) |
what am i supposed to be testing for exactly? if everything works as usual? |
Yes! |
|
these still dont work fyi - lmk when fixed n ill test again |
Remove ~/.config/rustmission/keymap.toml and try again |
okay tested again - it works ! |
rm-config/src/keymap.rs
Outdated
| utils::ConfigFetchingError::Toml(_) => anyhow::bail!(e), | ||
| _ => anyhow::bail!(e), |
There was a problem hiding this comment.
is the utils::ConfigFetchingError needed? since both are bailed .. unless we plan on handling it differently in the future, if so maybe can add a TODO?
There was a problem hiding this comment.
There's still io::Error that needs to be checked whether or not it's NotFound (in this case a default config is being placed). But those 2 match branches can be merged into one
|
@aidanaden Merge this if everything's okay |
* start implementing config * impl deserialize for keybinding * refactor(config): restructure * fix headers_hide * use indexmap * get rid of crate's event * fix help * refactor writing to lines in help * default config * fix uppercase letters * fix space * make help key in the bottom reflect reality * rename SoftQuit to Close * rename keymodifiers to crosstermkeymodifiers * merge 2 match branches * restructure keymap config
TODO: