Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display torrent location + move torrent location #29

Merged
merged 8 commits into from
Jun 30, 2024
Merged

feat: display torrent location + move torrent location #29

merged 8 commits into from
Jun 30, 2024

Conversation

aidanaden
Copy link
Contributor

@aidanaden aidanaden commented Jun 22, 2024 •
edited
Loading

closes #10

includes displaying torrent location (makes it easier to tell if moving locations is successful)

@aidanaden aidanaden self-assigned this Jun 22, 2024
@aidanaden aidanaden requested a review from micielski June 22, 2024 21:10
@aidanaden aidanaden added the done This issue or pull request has been completed label Jun 22, 2024
@aidanaden aidanaden added this to the 0.4 milestone Jun 22, 2024
@micielski micielski added the enhancement New feature or request label Jun 23, 2024
micielski
micielski requested changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@micielski micielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could we get rid of this directory column for the time being? For me every torrent is just in one default directory, and after I'll refactor the config then we can make it so that the headers will be configurable (the order and which to include)

rm-main/src/ui/tabs/torrents/tasks/move_torrent.rs Outdated Show resolved Hide resolved
rm-main/src/ui/tabs/torrents/tasks/move_torrent.rs Outdated Show resolved Hide resolved
@aidanaden
Copy link
Contributor Author

Also, could we get rid of this directory column for the time being? For me every torrent is just in one default directory, and after I'll refactor the config then we can make it so that the headers will be configurable (the order and which to include)

can we add this in the config? my torrents are all in separate folders based on their category - we can leave it disabled by default

@aidanaden
Copy link
Contributor Author

i can hold off till your refactor before merging this PR though .. having directory displayed is a requirement for me LOL

@aidanaden aidanaden changed the base branch from main to v0.4 June 30, 2024 10:09
@aidanaden aidanaden merged commit faafabe into intuis:v0.4 Jun 30, 2024
6 checks passed
micielski pushed a commit that referenced this pull request Jul 4, 2024
@aidanaden @micielski
feat: display torrent location + move torrent location (#29)
a3361a4 
* feat: display torrent location + move torrent location

* feat: lengthen torrent directory length

* fix: feedback

* fix: case sensitive folder location

* chore: remove old action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micielski micielski micielski requested changes

Assignees

@aidanaden aidanaden

Labels
done This issue or pull request has been completed enhancement New feature or request
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

m to move a torrent direcrory in torrents tab
2 participants
@aidanaden @micielski