be smarter about triggering render

intuis · Jul 16, 2024 · 54ed6f3 · 54ed6f3
1 parent 94c1327
commit 54ed6f3
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 12 deletions.
diff --git a/rm-main/src/app.rs b/rm-main/src/app.rs
@@ -180,15 +180,14 @@ impl App {
         match action {
             UpdateAction::SwitchToInputMode => {
                 self.mode = Mode::Input;
-                self.ctx.send_action(Action::Render);
             }
             UpdateAction::SwitchToNormalMode => {
                 self.mode = Mode::Normal;
-                self.ctx.send_action(Action::Render);
             }
 
             _ => self.main_window.handle_update_action(action),
-        }
+        };
+        self.ctx.send_action(Action::Render);
     }
 
     fn tick(&mut self) {

diff --git a/rm-main/src/ui/mod.rs b/rm-main/src/ui/mod.rs
@@ -71,7 +71,6 @@ impl Component for MainWindow {
             UpdateAction::Error(err) => {
                 let error_popup = ErrorPopup::new(err.title, err.description, err.source);
                 self.global_popup_manager.error_popup = Some(error_popup);
-                self.ctx.send_action(Action::Render);
             }
             action if self.tabs.current_tab == CurrentTab::Torrents => {
                 self.torrents_tab.handle_update_action(action)

diff --git a/rm-main/src/ui/tabs/search.rs b/rm-main/src/ui/tabs/search.rs
@@ -183,7 +183,6 @@ impl Component for SearchTab {
         match action {
             UpdateAction::SearchStarted => {
                 self.search_result_info.searching(ThrobberState::default());
-                self.ctx.send_action(Action::Render);
             }
             UpdateAction::SearchResults(magnets) => {
                 if magnets.is_empty() {
@@ -192,15 +191,13 @@ impl Component for SearchTab {
                     self.search_result_info.found(magnets.len());
                 }
                 self.table.set_items(magnets);
-                self.ctx.send_action(Action::Render);
             }
             _ => (),
         }
     }
 
     fn tick(&mut self) {
         self.search_result_info.tick();
-        self.ctx.send_action(Action::Render);
     }
 
     fn render(&mut self, f: &mut Frame, rect: Rect) {

diff --git a/rm-main/src/ui/tabs/torrents/mod.rs b/rm-main/src/ui/tabs/torrents/mod.rs
@@ -119,21 +119,17 @@ impl Component for TorrentsTab {
         match action {
             UpdateAction::SessionStats(stats) => {
                 self.bottom_stats.set_stats(stats);
-                self.ctx.send_action(Action::Render);
             }
             UpdateAction::FreeSpace(free_space) => {
                 self.bottom_stats.set_free_space(free_space);
-                self.ctx.send_action(Action::Render);
             }
             UpdateAction::SearchFilterApply(filter) => {
                 self.table_manager.filter.replace(filter);
                 self.table_manager.table.state.borrow_mut().select(Some(0));
-                self.ctx.send_action(Action::Render);
             }
             UpdateAction::SearchFilterClear => {
                 self.table_manager.filter = None;
                 self.table_manager.table.state.borrow_mut().select(Some(0));
-                self.ctx.send_action(Action::Render);
             }
             UpdateAction::UpdateTorrents(torrents) => {
                 self.table_manager.set_new_rows(torrents);

diff --git a/rm-main/src/ui/tabs/torrents/popups/files.rs b/rm-main/src/ui/tabs/torrents/popups/files.rs
@@ -178,7 +178,6 @@ impl Component for FilesPopup {
             let new_tree = Node::new_from_torrent(&torrent);
             self.torrent = Some(torrent);
             self.tree = new_tree;
-            self.ctx.send_action(Action::Render);
         }
     }