Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node & packages to latest version #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sp2hari
Copy link
Member

@sp2hari sp2hari commented Jan 26, 2023

No description provided.

Copy link

@faraz16iqbal faraz16iqbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested everything out. Looks good to me. Can we also update the variables from var to let / const?

@sp2hari
Copy link
Member Author

sp2hari commented Jan 30, 2023

@faraz16iqbal - I'm mostly planning to change packages in this PR. Can I make another PR on top of this after this merged for all the ES6 changes?

@faraz16iqbal
Copy link

@faraz16iqbal - I'm mostly planning to change packages in this PR. Can I make another PR on top of this after this merged for all the ES6 changes?

Sure @sp2hari! I think we can get this merged then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants