-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifier/documentation] Split clean_workspace fragment into fragments for different entity types #850
Changes from all commits
b844e99
66fd2eb
bb577c3
c3f83ce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Ensure clean workspace test step fragment | ||
|
||
Ensure a clean workspace for testing interactions with a DSS by removing any constraint references from the DSS that may have been left behind from testing efforts. | ||
|
||
## 🛑 Constraint references can be queried by ID check | ||
|
||
If an existing constraint reference cannot directly be queried by its ID, or if for a non-existing one the DSS replies with a status code different than 404, | ||
the DSS implementation is in violation of **[astm.f3548.v21.DSS0005,3](../../../../requirements/astm/f3548/v21.md)**. | ||
|
||
## 🛑 Constraint references can be searched for check | ||
|
||
A client with valid credentials should be allowed to search for constraint references in a given area. | ||
Otherwise, the DSS is not in compliance with **[astm.f3548.v21.DSS0005,4](../../../../requirements/astm/f3548/v21.md)**. | ||
|
||
## 🛑 Constraint reference removed check | ||
|
||
If an existing constraint cannot be deleted by its manager when providing the proper ID and OVN, the DSS implementation is in violation of | ||
**[astm.f3548.v21.DSS0005,3](../../../../requirements/astm/f3548/v21.md)**. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Ensure clean workspace test step fragment | ||
|
||
Ensure a clean workspace for testing interactions with a DSS by removing any operational intent references from the DSS that may have been left behind from testing efforts. | ||
|
||
## 🛑 Operational intent references can be queried by ID check | ||
|
||
If an existing operational intent reference cannot directly be queried by its ID, or if for a non-existing one the DSS replies with a status code different than 404, | ||
the DSS implementation is in violation of **[astm.f3548.v21.DSS0005,1](../../../../requirements/astm/f3548/v21.md)**. | ||
|
||
## 🛑 Operational intent references can be searched for check | ||
|
||
A client with valid credentials should be allowed to search for operational intents in a given area. | ||
Otherwise, the DSS is not in compliance with **[astm.f3548.v21.DSS0005,2](../../../../requirements/astm/f3548/v21.md)**. | ||
|
||
## 🛑 Operational intent reference removed check | ||
|
||
If an existing operational intent cannot be deleted when providing the proper ID and OVN, the DSS implementation is in violation of | ||
**[astm.f3548.v21.DSS0005,1](../../../../requirements/astm/f3548/v21.md)**. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# Ensure clean workspace test step fragment | ||
|
||
Ensure a clean workspace for testing interactions with a DSS by removing any subscriptions from the DSS that may have been left behind from testing efforts. | ||
|
||
## 🛑 Successful subscription search query check | ||
|
||
**[astm.f3548.v21.DSS0005,5](../../../../requirements/astm/f3548/v21.md)** requires the implementation of the DSS endpoint to allow callers to retrieve the subscriptions they created. | ||
|
||
## 🛑 Subscription can be queried by ID check | ||
|
||
If the DSS cannot be queried for the existing test ID, the DSS is likely not implementing **[astm.f3548.v21.DSS0005,5](../../../../requirements/astm/f3548/v21.md)** correctly. | ||
|
||
## 🛑 Subscription can be deleted check | ||
|
||
**[astm.f3548.v21.DSS0005,5](../../../../requirements/astm/f3548/v21.md)** requires the implementation of the DSS endpoint to allow callers to delete subscriptions they created. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,9 +24,11 @@ Checks that implicit subscriptions are properly created, mutated and cleaned up. | |
|
||
## Setup test case | ||
|
||
### [Ensure clean workspace test step](clean_workspace.md) | ||
### Ensure clean workspace test step | ||
|
||
This step ensures that no OIRs with the known test IDs exists in the DSS. | ||
#### [Clean any existing OIRs with known test IDs](clean_workspace_op_intents.md) | ||
|
||
#### [Clean any existing subscriptions with known test IDs](clean_workspace_subs.md) | ||
|
||
## Single OIR implicit subscription is removed upon OIR deletion test case | ||
|
||
|
@@ -142,9 +144,13 @@ the DSS is in violation of **[astm.f3548.v21.DSS0005,1](../../../../requirements | |
|
||
This test case verifies that implicit subscriptions are properly removed if they become unnecessary following the mutation of an OIR. | ||
|
||
### [Ensure clean workspace test step](clean_workspace.md) | ||
### Ensure clean workspace test step | ||
|
||
<!-- TODO(Shastick): Why do we need to reclean the workspace at this point? We already ensured it was clean before starting the test; don't we know exactly what happened in the test and therefore know that it's already clean (or something failed)? If a previous test case created something that we don't need/want in later test cases, the original test case should clean up at the end of the test case. --> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are the addition of those TODOs intended? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes -- it seemed difficult to create separate Issues that referred to exactly the right place and it may certainly be the case that these TODOs are not actually problems. My in-between solution was to add these with the idea that Julien can search for TODO(Shastick) when he returns and address them then. |
||
|
||
#### [Clean any existing OIRs with known test IDs](clean_workspace_op_intents.md) | ||
|
||
Reset the workspace for this test case. | ||
#### [Clean any existing subscriptions with known test IDs](clean_workspace_subs.md) | ||
|
||
### Create two OIRs with implicit subscription test step | ||
|
||
|
@@ -190,9 +196,13 @@ the DSS is failing to properly manage implicit subscriptions for OIRs, and is th | |
|
||
This test case checks that a DSS will properly expand an implicit subscription to cover an OIR that is being attached to it. | ||
|
||
### [Ensure clean workspace test step](clean_workspace.md) | ||
### Ensure clean workspace test step | ||
|
||
<!-- TODO(Shastick): Why do we need to reclean the workspace at this point? We already ensured it was clean before starting the test; don't we know exactly what happened in the test and therefore know that it's already clean (or something failed)? If a previous test case created something that we don't need/want in later test cases, the original test case should clean up at the end of the test case. --> | ||
|
||
#### [Clean any existing OIRs with known test IDs](clean_workspace_op_intents.md) | ||
|
||
Reset the workspace for this test case. | ||
#### [Clean any existing subscriptions with known test IDs](clean_workspace_subs.md) | ||
|
||
### Create an OIR with implicit subscription test step | ||
|
||
|
@@ -221,6 +231,8 @@ in which case the DSS is in violation of **[astm.f3548.v21.DSS0005,1](../../../. | |
|
||
Ensure that the attached implicit subscription has been expanded | ||
|
||
## Cleanup | ||
|
||
### [Remove OIRs created during this test](clean_workspace_op_intents.md) | ||
|
||
## [Cleanup](./clean_workspace.md) | ||
### [Remove subscriptions created during this test](clean_workspace_subs.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the changes in that file expected? They are not covered by the PR description.
But they LGTM in themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not mean to include these changes in this PR, but given you've reviewed them now and LGTM, I'll update the description to mention them and then keep them in the PR.