[uss_qualifier] netrid: net0260 - check SP correctly reports horizontal accuracy #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
net-0260-horizontal-accuracy
branch
from
4899dc0 to
c3dc163
Compare
mickmis
approved these changes
Nov 12, 2024
| @@ -938,6 +938,19 @@ def _evaluate_normal_sp_observation( | |||
| details=f"{mapping.injected_flight.uss_participant_id}'s flight with injection ID {mapping.injected_flight.flight.injection_id} in test {mapping.injected_flight.test_id} had telemetry index {mapping.telemetry_index} at {injected_telemetry.timestamp} with vertical speed {injected_telemetry.vertical_speed}, but Service Provider reported vertical speed {mapping.observed_flight.flight.raw.current_state.vertical_speed} at {mapping.observed_flight.query.query.request.initiated_at}", | |||
| ) | |||
|
|
|||
| with self._test_scenario.check( | |||
There was a problem hiding this comment.
This is relying on observed_position and injected_position. Move this block closer up where those are defined? There is a check in the middle that does not rely on it.
mickmis
reviewed
Nov 12, 2024
| ) as check: | ||
| if ( | ||
| injected_position.accuracy_h.value | ||
| != observed_position.accuracy_h.value |
There was a problem hiding this comment.
Coming back to this after review: If accuracy_h is None, this will fail. This should be checked before.
Shastick
force-pushed
the
net-0260-horizontal-accuracy
branch
2 times, most recently
from
836fd42 to
3b073b1
Compare
Shastick
force-pushed
the
net-0260-horizontal-accuracy
branch
from
3b073b1 to
4c7afb1
Compare
mickmis
approved these changes
Nov 14, 2024
| [mapping.injected_flight.uss_participant_id], | ||
| ) as check: | ||
| if ( | ||
| "accuracy_h" in observed_position |
There was a problem hiding this comment.
FTR for the later pass on those, we probably should fail the check if the accuracy is injected but not observed (not the case here).
(I think I left a similar comment for the vertical accuracy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #754