[uss_qualifier] scd sub-interactions: also search for any active subs at cleanup #813
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The active subs cleanup may be a useful thing to do, but I don't think it does anything to address #809. I think the root cause of #809 is that this query is not recorded in the scenario. |
|
Oh my, I got a bit confused there. Will open a separate PR to address the recording of the query, and will leave this PR open (but remove the mention of the issue) as the cleanup step does document a subscription search query, so it still makes sense to add it. |
Shastick
force-pushed
the
sub-interactions-add-search-cleanup
branch
from
cc2e4f4 to
d0d51f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a missing search and deletion of possible active subscriptions in the setup and cleanup of
SubscriptionInteractions.This corresponds to both the original intent of how the scenario should be set and cleaned up, and to how the scenario was originally documented.