[uss_qualifier] scd: expand OIRSimple scenario to check mutation requires the correct OVN #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Shastick
force-pushed
the
oir-simple-mutation-scenario
branch
3 times, most recently
from
b276cc8
to
d63e300
Compare
BenjaminPelletier
approved these changes
Sep 11, 2024
| except QueryError as qe: | ||
| self.record_queries(qe.queries) | ||
| if qe.cause_status_code in [400, 409]: | ||
| # An empty OVN can be seen as both an incorrect parameter as well as a conflict |
There was a problem hiding this comment.
Because the OVN is in the resource path, the version of could be viewed as not existing, so we should accept 404 here as well.
Shastick
force-pushed
the
oir-simple-mutation-scenario
branch
from
d63e300
to
32a7944
Compare
Shastick
force-pushed
the
oir-simple-mutation-scenario
branch
from
32a7944
to
4e3b6c7
Compare
Shastick
force-pushed
the
oir-simple-mutation-scenario
branch
from
4e3b6c7
to
78b8e09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another stepping stone towards explicitly covering #760