Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier] Add documentation for solo happy path scenario #752

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

BenjaminPelletier
Copy link
Member

This PR begins to address #751 by adding scenario documentation for a simple, solo, happy-path flight planning test scenario. The empty test scenario implementation parses/processes inputs, but the core implementation is left to a follow-up PR.

Sequence view generation is also fixed to correctly handle a test scenario with no events.

The other .md changes are via autogeneration in make format.

@BenjaminPelletier BenjaminPelletier marked this pull request as ready for review August 14, 2024 17:33
flight_planners_source: flight_planners
roles:
- tested_uss
on_failure: Continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it stop since this would mean a USS is not able to simply plan a flight ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be nice to take a specific USS out of the test if they couldn't do this basic thing (but we can't do that currently), but Abort would abort the entire test and therefore one problematic USS would prevent test coverage for other USSs even when the test coverage of the other USSs should be manageable even in the presence of the non-functional USS.

</tr>
</table>

Because the scenario involves activation of intents, all activated intents must be active during the execution of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is not totally clear to me. Could you please clarify?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text was copied over from our two existing planning scenarios -- I've updated it in all 3 places.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BenjaminPelletier BenjaminPelletier merged commit 688869b into interuss:main Aug 20, 2024
20 checks passed
@BenjaminPelletier BenjaminPelletier deleted the solo-happy-path branch August 20, 2024 14:53
github-actions bot added a commit that referenced this pull request Aug 20, 2024
* Add documentation for solo happy path scenario

* Improve intent timing notes 688869b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants