-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifier] initial constraint reference sync scenario - creation - 1/n #704
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
...toring/uss_qualifier/scenarios/astm/utm/dss/fragments/cr/crud/create_correct.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Create constraint reference test step fragment | ||
|
||
This test step fragment validates that: | ||
- a query to create a constraint reference with valid parameters succeeds | ||
- the response to the query conforms to the OpenAPI specification | ||
- the content of the response reflects the created constraint reference | ||
|
||
## [Query Success](./create_query.md) | ||
|
||
Check query succeeds | ||
|
||
## [Response Format](./create_format.md) | ||
|
||
Check response format | ||
|
||
## 🛑 Create constraint reference response content is correct check | ||
|
||
A successful constraint reference creation query is expected to return a body, the content of which reflects the created constraint reference. | ||
If the content of the response does not correspond to what was requested, the DSS is failing to implement **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)**. | ||
|
||
This check will usually be performing a series of sub-checks from the [validate](../validate) fragments. |
9 changes: 9 additions & 0 deletions
9
monitoring/uss_qualifier/scenarios/astm/utm/dss/fragments/cr/crud/create_format.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# Create constraint reference response format test step fragment | ||
|
||
This test step fragment validates that a constraint references creation returns a body in the correct format. | ||
|
||
## 🛑 Create constraint reference response format conforms to spec check | ||
|
||
The response to a successful constraint reference creation query is expected to conform to the format defined by the OpenAPI specification under the `A3.1` Annex of ASTM F3548−21. | ||
|
||
If it does not, the DSS is failing to implement **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)**. |
8 changes: 8 additions & 0 deletions
8
monitoring/uss_qualifier/scenarios/astm/utm/dss/fragments/cr/crud/create_query.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# Create constraint reference test step fragment | ||
|
||
This test step fragment validates that a query to create a constraint reference with valid parameters succeeds | ||
|
||
## 🛑 Create constraint reference query succeeds check | ||
|
||
As per **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)**, the DSS API must allow callers to create a constraint reference with either one or both of the | ||
start and end time missing, provided all the required parameters are valid. |
51 changes: 51 additions & 0 deletions
51
...oring/uss_qualifier/scenarios/astm/utm/dss/fragments/cr/validate/correctness.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# Validate the content of a constraint reference test step fragment | ||
|
||
This test step fragment attempts to validate the content of a single constraint reference returned by the DSS. | ||
|
||
The code for these checks lives in the [cr_validator.py](../../../validators/cr_validator.py) class. | ||
|
||
## ⚠️ Returned constraint reference ID is correct check | ||
|
||
If the returned constraint reference ID does not correspond to the one specified in the creation parameters, | ||
**[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)** is not respected. | ||
|
||
## ⚠️ Returned constraint reference has a manager check | ||
|
||
If the returned constraint reference has no manager defined, **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)** is not respected. | ||
|
||
## ⚠️ Returned constraint reference manager is correct check | ||
|
||
The returned manager must correspond to the identity of the client that created the constraint at the DSS, | ||
otherwise the DSS is in violation of **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)**. | ||
|
||
## ⚠️ Returned constraint reference has an USS base URL check | ||
|
||
If the returned constraint reference has no USS base URL defined, **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)** is not respected. | ||
|
||
## ⚠️ Returned constraint reference base URL is correct check | ||
|
||
The returned USS base URL must be prefixed with the USS base URL that was provided at constraint reference creation, otherwise the DSS is in violation of **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)**. | ||
|
||
## ⚠️ Returned constraint reference has a start time check | ||
|
||
If the returned constraint reference has no start time defined, **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)** is not respected. | ||
|
||
## ⚠️ Returned start time is correct check | ||
|
||
The returned start time must be the same as the provided one, otherwise the DSS is in violation of **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)**. | ||
|
||
## ⚠️ Returned constraint reference has an end time check | ||
|
||
Constraint references need a defined end time in order to limit their duration: if the DSS omits to set the end time, it will be in violation of **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)**. | ||
|
||
## ⚠️ Returned end time is correct check | ||
|
||
The returned end time must be the same as the provided one, otherwise the DSS is in violation of **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)**. | ||
|
||
## ⚠️ Returned constraint reference has an OVN check | ||
|
||
If the returned constraint reference has no OVN defined, **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)** is not respected. | ||
|
||
## ⚠️ Returned constraint reference has a version check | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Implementation of this check is missing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch. There was no check for the OVN either, added it as well. |
||
|
||
If the returned constraint reference has no version defined, **[astm.f3548.v21.DSS0005,3](../../../../../../../requirements/astm/f3548/v21.md)** is not respected. |
1 change: 1 addition & 0 deletions
1
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/__init__.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
from .subscription_synchronization import SubscriptionSynchronization | ||
from .op_intent_ref_synchronization import OIRSynchronization | ||
from .uss_availability_synchronization import USSAvailabilitySynchronization | ||
from .constraint_ref_synchronization import CRSynchronization |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the context of this PR, some of the fragments may seem like they are overkill. However, the rest of the scenario as well as the upcoming update of the authentication check scenario will make use of them.
(I'm essentially reusing the approach that was taken for the scenarios focused on operation intent references)