Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier] DSS0210,A2-7-2,4 initial subscription <-> OIR interactions scenario: oir creation (1/n) #582

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

Shastick
Copy link
Contributor

@Shastick Shastick commented Mar 21, 2024

This PR adds a new scenario that will hold all checks related to interactions between OIRs and subscriptions.

It starts with checking simple interactions when subscriptions currently exist and multiple OIRs with implicit subscriptions are added

This begins work for #541

@Shastick Shastick changed the title DSS0210 initial subscription <-> OIR interactions scenario: oir creation [qualifier] dss0210 initial subscription <-> OIR interactions scenario: oir creation Mar 21, 2024
@Shastick Shastick force-pushed the sub-oir-interactions-1-create-oirs branch from 47d173a to 6aa6f8b Compare March 21, 2024 19:37
@Shastick Shastick marked this pull request as draft March 21, 2024 19:37
@Shastick Shastick force-pushed the sub-oir-interactions-1-create-oirs branch 4 times, most recently from 41f5ee2 to ed8a191 Compare March 21, 2024 20:24
@barroco barroco changed the title [qualifier] dss0210 initial subscription <-> OIR interactions scenario: oir creation [uss_qualifier] dss0210 initial subscription <-> OIR interactions scenario: oir creation Mar 21, 2024
@Shastick Shastick marked this pull request as ready for review March 22, 2024 07:42
@Shastick Shastick force-pushed the sub-oir-interactions-1-create-oirs branch 2 times, most recently from c6621c0 to aab8222 Compare March 22, 2024 13:27
@Shastick Shastick changed the title [uss_qualifier] dss0210 initial subscription <-> OIR interactions scenario: oir creation [uss_qualifier] DSS0210,A2-7-2,4 initial subscription <-> OIR interactions scenario: oir creation Mar 22, 2024
@Shastick Shastick force-pushed the sub-oir-interactions-1-create-oirs branch 2 times, most recently from 13a76be to 454724d Compare March 22, 2024 17:46
@Shastick Shastick changed the title [uss_qualifier] DSS0210,A2-7-2,4 initial subscription <-> OIR interactions scenario: oir creation [uss_qualifier] DSS0210,A2-7-2,4 initial subscription <-> OIR interactions scenario: oir creation (1/n) Mar 22, 2024
@Shastick Shastick force-pushed the sub-oir-interactions-1-create-oirs branch 2 times, most recently from c474451 to ba2a4ea Compare March 22, 2024 22:15
Copy link
Member

@BenjaminPelletier BenjaminPelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple comments, but I don't think they should block merging -- they can be addressed afterward if/when appropriate.

@mickmis mickmis force-pushed the sub-oir-interactions-1-create-oirs branch from ba2a4ea to 1f4855a Compare March 25, 2024 10:40
@mickmis
Copy link
Contributor

mickmis commented Mar 25, 2024

FYI @BenjaminPelletier I took over this PR. I implemented your feedback and made some small additional cosmetic changes. Merging this PR once CI is green.

@mickmis mickmis merged commit fefcc5f into interuss:main Mar 25, 2024
9 checks passed
github-actions bot added a commit that referenced this pull request Mar 25, 2024
…tions scenario: oir creation (1/n) (#582)

* DSS0210 prepare sub interactions scenario: oir creation

* PR feedback; cosmetic changes

---------

Co-authored-by: Mickaël Misbach <[email protected]> fefcc5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants