-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifier] SCD subscriptions can be mutated and deleted on every DSS of a deployment #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmis
reviewed
Mar 13, 2024
monitoring/uss_qualifier/scenarios/astm/utm/dss/test_step_fragments.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.md
Outdated
Show resolved
Hide resolved
Shastick
force-pushed
the
dss0020-sub-delete-any
branch
2 times, most recently
from
March 14, 2024 07:17
79b44b5
to
24a098c
Compare
Shastick
force-pushed
the
dss0020-sub-delete-any
branch
from
March 14, 2024 20:50
24a098c
to
0caf523
Compare
Shastick
force-pushed
the
dss0020-sub-delete-any
branch
4 times, most recently
from
March 19, 2024 15:30
18ecd71
to
35044ef
Compare
Shastick
force-pushed
the
dss0020-sub-delete-any
branch
from
March 19, 2024 15:51
35044ef
to
6614468
Compare
mickmis
reviewed
Mar 20, 2024
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
Shastick
force-pushed
the
dss0020-sub-delete-any
branch
3 times, most recently
from
March 20, 2024 14:27
8068998
to
a86b29d
Compare
Shastick
force-pushed
the
dss0020-sub-delete-any
branch
from
March 20, 2024 14:32
a86b29d
to
0de75f1
Compare
mickmis
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the existing
SubscriptionSynchronization
test scenario to also check that:Resolves #547
Partially covers #548