[uss_qualifier] DSS0210,1d – check that DSS properly propagates a subscription's area #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
dss0210-subs-area-sync
branch
2 times, most recently
from
fd20935 to
1f45edd
Compare
Shastick
force-pushed
the
dss0210-subs-area-sync
branch
2 times, most recently
from
c3e41ad to
209e64a
Compare
mickmis
approved these changes
Mar 12, 2024
| self._enclosing_sub_area_volume4d = Volume4D( | ||
| volume=Volume3D( | ||
| outline_polygon=geo.Polygon.from_coords( | ||
| [(p.lat().degrees, p.lng().degrees) for p in enclosing_area] |
There was a problem hiding this comment.
nit: there is no such function to do this in the geo lib?
There was a problem hiding this comment.
Not directly, though I could add something there.
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/synchronization/subscription_synchronization.py
Show resolved
Hide resolved
Shastick
force-pushed
the
dss0210-subs-area-sync
branch
from
209e64a to
536a072
Compare
Shastick
force-pushed
the
dss0210-subs-area-sync
branch
from
536a072 to
2a2d390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check of DSS0210,1d: make sure that DSSes that a subscription was synced to know about the sub's area.
(This PR sits on top of #537, only the last commit here reflects the intended change in this PR)