[uss_qualifier/scenarios/netrid/dss_interoperability] Avoid timeouts in notifications to dummy subscriptions #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
dss-interop-fixes
branch
from
4de8c05 to
613446b
Compare
Shastick
commented
Feb 23, 2024
Comment on lines
601
to
605
| LONG_WAIT_SEC, | ||
| "Subscriptions needs to expire so we can check they don't trigger notifications", |
There was a problem hiding this comment.
Notes:
- description string updated from my understanding of the code.
- the longer wait time aims at making sure that the subscriptions created at step9 above have expired
Shastick
commented
Feb 23, 2024
| @@ -515,7 +518,9 @@ def step9(self): | |||
| created_sub = dss.put_sub( | |||
| check, | |||
| sub_id=sub_2.uuid, | |||
| **_default_params(datetime.timedelta(seconds=SHORT_WAIT_SEC)), | |||
| **_default_params( | |||
| datetime.timedelta(seconds=SHORT_SUBSCRIPTION_DURATION_SEC) | |||
There was a problem hiding this comment.
If we run into problems again in the future, or if users report that this is brittle when testing real deployments, we could consider:
- making this a configurable part of the scenario, giving users the possibility to trade off execution speed vs delay sensibility
- computing these delays according to the number of DSS's, based on allowed p95 latencies
Shastick
force-pushed
the
dss-interop-fixes
branch
from
613446b to
36306c1
Compare
|
Will reopen when the root-cause is addressed |
Shastick
force-pushed
the
dss-interop-fixes
branch
3 times, most recently
from
e6e5956 to
55b4925
Compare
Shastick
force-pushed
the
dss-interop-fixes
branch
from
55b4925 to
269547c
Compare
|
This seems to be consistently passing again. |
Shastick
changed the title
mickmis
approved these changes
Feb 23, 2024
mickmis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't attempt to notify the short-lived subscriptions that the
dss_interoperabilityscenario created, as these result in requests toexample.comthat time out and cause the scenario's assumptions to break.(This uses the recently introduced
do_not_notifyparameter.)This also updates the dummy
uss_base_urlfromexample.comtoexample.interuss.orgto take a step forward regarding #275Evidence this seems to work:
See #517