[uss_qualifier] Use mock_uss background tasks for atproxy_client #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
approved these changes
Feb 17, 2023
| "atproxy client worker {} from process ID {} is stopping", | ||
| worker_id, | ||
| os.getpid(), | ||
| def _get_basic_auth() -> Tuple[str, str]: |
There was a problem hiding this comment.
To be replaced with the new configuration from #46
There was a problem hiding this comment.
Yeah, I try to keep my PRs mostly disjoint, but there's often a little bit of overlap. Will definitely merge main into this branch and resolve before merging this branch back to main.
There was a problem hiding this comment.
I just put it as a reminder. PR are perfect like that. Thanks !
…uss-tasks-atproxy_client
BenjaminPelletier
force-pushed
the
uss_qualifier/mock_uss-tasks-atproxy_client
branch
from
eb1122f to
f961c0e
Compare
BenjaminPelletier
deleted the
uss_qualifier/mock_uss-tasks-atproxy_client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #40 to use shared mock_uss background tasks for atproxy_client functionality as well as tracer.
Also add retries to atproxy_client's response notifications to atproxy in an effort to address #28.
The diff will look smaller if "Hide whitespace" is checked in the diff view settings.