-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifier] warn upon unattributed or untyped queries, set query types in many instances #436
[uss_qualifier] warn upon unattributed or untyped queries, set query types in many instances #436
Conversation
5ffd9c3
to
6167a65
Compare
SQUELCH_WARN_ON_QUERY_TYPE = [ | ||
# Posting an ISA is done for notifications: we can't always know the participant ID | ||
QueryType.F3411v19USSPostIdentificationServiceArea, | ||
QueryType.F3411v22aUSSPostIdentificationServiceArea, | ||
# When querying for display data and flight details, we don't always know the participant ID | ||
QueryType.F3411v19USSGetDisplayData, | ||
QueryType.F3411v22aUSSGetDisplayData, | ||
QueryType.F3411v19USSGetFlightDetails, | ||
QueryType.F3411v22aUSSGetFlightDetails, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted for this solution to avoid noisy warnings that have no obvious way of being fixed.
For situations where we should be able to set the participant_id, we still have the aggregate checks logging a single warning with all queries missing a participant_id: this feels like an acceptable trade-off to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good approach to me :)
6167a65
to
b4f6ee6
Compare
|
||
# Flight injection (test harness) | ||
|
||
F3411v19USSCreateTest = "rid.f3411.v19.sp.createTest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want these IDs to be universally unique, so starting with the organization that defined them is good, then following the specificity chain down -- here, I would suggest interuss.automated_testing.rid.v1.injection.createTest (and similarly for the other following endpoints).
monitoring/uss_qualifier/scenarios/astm/netrid/common/dss/isa_validation.py
Outdated
Show resolved
Hide resolved
b4f6ee6
to
02a4bb5
Compare
Did a pass of cleanup and renaming. Happy new year! |
4af7674
to
7b14385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; just one small comment
monitoring/monitorlib/mutate/rid.py
Outdated
is_mutation = isa_version is None | ||
mutation = "create" if is_mutation else "update" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are two errors which net out to the desired behavior that would be fixed by renaming is_mutation
to is_creation". (When
isa_version` is None, that's a creation rather than a mutation/update)
is_mutation = isa_version is None | |
mutation = "create" if is_mutation else "update" | |
is_creation = isa_version is None | |
mutation = "create" if is_creation else "update" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you! It's pretty rare that two wrongs will do a right :)
7b14385
to
c7ffe33
Compare
This should fix most if not all non-attributed queries in the context of F3411 and resolve #431
I found no warnings when running
configurations.dev.netrid_v19
andconfigurations.dev.netrid_v22a
: there might be a few stray ones remaining with other configurations, and these can be fixed on-the-go when we run into them.