[uss_qualifier] Identify duplicate record_query calls #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punamverma
approved these changes
Dec 21, 2023
barroco
approved these changes
Dec 21, 2023
github-actions bot
added a commit
that referenced
this pull request
Dec 21, 2023
Identify duplicate record_query calls 9f4abb5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only mechanism we have to ensure that a query isn't recorded in a test report more than once is correctness of all calling code. This PR introduces a loud warning message on the console if and when a query is recorded multiple times, but it stops short of aborting test execution. This should allow us to easily detect if this happens in the future. I don't believe it happens currently, though I have not performed an exhaustive search.